Skip to content

fix: deduplicate posts in feed to prevent duplicate rendering #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pnvasanth merged 1 commit into from
Feb 26, 2026
+6 −0
Merged

fix: deduplicate posts in feed to prevent duplicate rendering #5577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/shared/src/hooks/useFeed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,14 @@ export default function useFeed<T>(
const plusEntryAsFirstCard = settings?.plusEntry?.flags?.asFirstCard;

if (feedQuery.data) {
const seenPostIds = new Set<string>();
Copy link
Contributor

@rebelchris rebelchris Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against it but just waiting for Ante to check the API part

Copy link
Contributor

@capJavert capJavert Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we not already have this discussion? 😆

Copy link
Contributor

@capJavert capJavert Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5480 (comment)

newItems = feedQuery.data.pages.reduce((acc, { page }, pageIndex) => {
page.edges.forEach(({ node }, index: number) => {
if (seenPostIds.has(node.id)) {
return;
}
seenPostIds.add(node.id);

const adIndex = acc.length;
const adItem = getAd({ index: adIndex });

Expand Down