chore(shared): strict migration batch 3b (feed, log hooks)#5581
Open
rebelchris wants to merge 4 commits intomainfrom
Open
chore(shared): strict migration batch 3b (feed, log hooks)#5581rebelchris wants to merge 4 commits intomainfrom
rebelchris wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
capJavert
reviewed
Feb 25, 2026
Comment on lines
58
to
61
| const callback = (event: Event) => { | ||
| if (!(event instanceof CustomEvent)) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
not sure event will really be instanceOf CustomEvent every time, I would use as here for now even though its not ideal
capJavert
reviewed
Feb 25, 2026
| const handleLifecycle = (event: CustomEvent) => | ||
| lifecycleCallbackRef.current(event); | ||
| const handleLifecycle = (event: Event) => { | ||
| if (!(event instanceof CustomEvent)) { |
Contributor
Author
|
@claude see ante's feedback please adjust |
Contributor
|
Claude finished @rebelchris's task in 52s —— View job Adjusted
|
Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/sharedhooks/feed/*andhooks/log/*Files
src/hooks/feed/*src/hooks/log/*Validation
pnpm --filter shared lint:fixpnpm --filter shared lintpnpm --filter shared typecheck:strict(batch-3 target scope clean in combined validation)pnpm --filter extension typecheck✅pnpm --filter shared test -- --testPathPattern="src/hooks/(contentPreference|feed|log|notifications|search|squads|translation)"✅Notes
pnpm --filter shared typecheckandpnpm --filter webapp typecheckfail on existing repo-wide baseline issues unrelated to this batch in the current environment.pnpm --filter webapp buildfails at prerender with TLS cert error (UNABLE_TO_GET_ISSUER_CERT_LOCALLY) after successful compile.Preview domain
https://codex-eng-803-batch3-feed-log.preview.app.daily.dev