Skip to content

feat(profile): increase showcase limit to 5 and add rarity glow to thumbnails #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmarTrebinjac merged 1 commit into from
Feb 26, 2026
+17 −3
Merged

feat(profile): increase showcase limit to 5 and add rarity glow to thumbnails #5600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shared/src/components/modals/AchievementShowcaseModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { useShowcaseAchievements } from '../../hooks/profile/useShowcaseAchievem
import { useProfileAchievements } from '../../hooks/profile/useProfileAchievements';
import { useToastNotification } from '../../hooks/useToastNotification';

const MAX_SHOWCASE = 3;
const MAX_SHOWCASE = 5;

export interface AchievementShowcaseModalProps extends ModalProps {
user: PublicProfile;
Expand Down
18 changes: 16 additions & 2 deletions packages/shared/src/features/profile/components/achievements/ProfileAchievementShowcase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ReactElement } from 'react';
import React from 'react';
import classNames from 'classnames';
import type { PublicProfile } from '../../../../lib/user';
import { useShowcaseAchievements } from '../../../../hooks/profile/useShowcaseAchievements';
import { useProfilePreview } from '../../../../hooks/profile/useProfilePreview';
Expand All @@ -21,7 +22,9 @@ import { formatDate, TimeFormatType } from '../../../../lib/dateFormat';
import {
getAchievementRarityTier,
AchievementRarityTier,
rarityGlowClasses,
} from './achievementRarity';
import { RaritySparkles } from './RaritySparkles';
import { useLazyModal } from '../../../../hooks/useLazyModal';
import { LazyModal } from '../../../../components/modals/common/types';

Expand Down Expand Up @@ -97,12 +100,23 @@ export function ProfileAchievementShowcase({
trigger={
<button
type="button"
className="flex size-16 shrink-0 items-center justify-center rounded-14"
className={classNames(
'relative flex size-16 shrink-0 items-center justify-center rounded-14',
rarityTier
? [
'overflow-visible border',
rarityGlowClasses[rarityTier],
]
: 'overflow-hidden',
)}
>
{rarityTier && (
<RaritySparkles tier={rarityTier} size="compact" />
)}
<LazyImage
imgSrc={achievement.image}
imgAlt={achievement.name}
className="size-16 rounded-14 object-cover"
className="size-full rounded-14 object-cover"
fallbackSrc="https://daily.dev/default-achievement.png"
/>
</button>
Expand Down