5.6.35 maintenance multi midi tog#203
5.6.35 maintenance multi midi tog#203dnaldoog wants to merge 83 commits intodamiensellier:masterfrom
Conversation
…ECT FALSE * **UPDATED** Version from 5.6.34 to 5.6.35 * **UPDATED** CMakeLists IS_MIDI_EFFECT FALSE
…ldoog/CtrlrX into 5.6.35-Maintenance_modasdata (1) Removed libopen_usb from CtrlrLuaManager (2) Copy-paste bug in createLuaStateAudio()
This reverts commit 2894951.
This reverts commit 2129825.
|
H̶i̶ ̶J̶o̶h̶n̶,̶ ̶I̶ ̶j̶u̶s̶t̶ ̶c̶h̶e̶c̶k̶e̶d̶ ̶y̶o̶u̶r̶ ̶n̶e̶w̶e̶s̶t̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶a̶n̶d̶ ̶C̶m̶d̶+̶H̶ ̶c̶r̶a̶s̶h̶e̶s̶ ̶t̶h̶e̶ ̶a̶p̶p̶ ̶s̶i̶n̶c̶e̶ ̶b̶o̶t̶h̶ ̶h̶e̶l̶p̶ ̶w̶i̶n̶d̶o̶w̶s̶ ̶a̶r̶e̶ ̶a̶s̶s̶i̶g̶n̶e̶d̶ ̶t̶o̶ ̶t̶h̶e̶ ̶s̶a̶m̶e̶ ̶s̶h̶o̶r̶t̶c̶u̶t̶.̶ EDIT: cmd+H is not crashing ctrlrx actually, it's hiding the main window on mac because it's a macOS shortcut. maybe cmd+? should be ok or F1 maybe... Those help windows should be also resizeable and should have the possibility to be kept open but without focus so that the user could type in a property in the pane or message editor while reading the help. (not sure how to do that, it may be an option from the open popup window function's arguments. I'll take a look at a nice way to implement a window with text and shortcuts from an index so that we could get a help window like MS word etc I'm pretty sure there's a class for that in JUCE. Thanks for your work John Damien EDIT: btw i saw your [CI Skip] note in the commit title, the action is still running anyway and it's a good thing because I can download your installer and try the app to check your progress. I suggest you still run the action it's pretty handy. |
|
EDIT: cmd+H is not crashing ctrlrx actually, it's hiding the main window on mac because it's a macOS shortcut. maybe cmd+? should be ok or F1 maybe... |
|
I just checked the demorunner from JUCE and the best way to implement a helper would be with a popup window from juce calling a WebBrowserComponent to read a local or distant html file . This way we could update the content on the go with new links to tutorials etc without the need to recompile everytime we update it. |
|
... This is where the wiki from the CtrlrX repo would be handy. The helper window could show this particular page with the index etc |
|
Yes we need a stable url , CtrlrX wiki is perfect it will always be available. I will check the rework token editor tonight when back home. |
|
Hi John, I just checked. Everything seems good 👍 Another little thing to improve is a look and feel check for the multimessage list and icons. They need to follow the global look and feel like we did for the text (bold, italic, size etc) icons in the property lanes. Apart from that everything is fine! I think I'll work on the wiki page this winter holidays so that we just can call a url from the components to display in the help window. I'm thinking about a nice table index and sub categories for the wiki to make everything look good and practical so that we have a solid helper database to expend from. The help window will then be a WebBrowserComponent . I need to work on CtrlrX.org as well which is a lot to do. I'll definitely link this GitHub wiki from it for the help page. |
|
Okay, all points noted.
In a new branch, I’m working on. I have created a markdown parser that
loads formatted text into those two help windows and with a view to adding
even more help windows in the future. I’ll try to finish it maybe tomorrow
and see what you think of that as a possibility, or we can just ditch that
altogether
I still haven’t tested some of those windows in Wayland; they will probably
crash Wayland but when I sort that out, I can maybe if def everything so
that when it’s just Wayland, there’s the restricted title bar. I already
added code to detect Wayland, but I haven’t used it yet.
How do you change The icon colors ? By loading a different SVG depending
on whether the same as darker or lighter?
JG.
…On Thu, Dec 11, 2025 at 22:02 Damien Sellier ***@***.***> wrote:
*damiensellier* left a comment (damiensellier/CtrlrX#203)
<#203 (comment)>
Hi John, I check. Everything seems good 👍
There's 2 things to improve:
We need a statement to have the native title bar for all systems but the
Linux Wayland. And inside this condition we needed to check for the global
preferences native title bar vs JUCE title bar.
Because right now, the new help windows are set to native bar false by
default.
Another little thing to improve is a look and feel check for the
multimessage list and icons. They need to follow the global look and feel
like we did for the text (bold, italic, size etc) icons in the property
lanes.
Right now if I use a dark lnf scheme the icons in the multi message box
are black on black or white on white. We need to call the default colour
from the scheme components definitions. Not solid colours.
Apart from that everything is fine!
I think I'll work on the wiki page this winter holidays so that we just
can call a url from the components to display in the help window. I'm
thinking about a nice table index and sub categories for the wiki to make
everything look good and practical so that we have a solid helper database
to expend from.
The help window will then be a WebBrowserComponent .
I need to work on CtrlrX.org as well which is a lot to do. I'll definitely
link this GitHub wiki from it for the help page.
Dominique @dobo365 <https://github.com/dobo365> wanted to resurrect the
property description/ID hyperlinks to the wiki page that's definitely in
the line.
—
Reply to this email directly, view it on GitHub
<#203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKFXQ5VRQ4ZTI6AOGRUS7D4BFTNTAVCNFSM6AAAAACN4R47S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBRHAZDEMJXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
For the color switch related to the lnf I'll give you the code I used as an example tonight when back home. |
|
I just remembered the way I updated the Icon color, it was for the eyedropper tool , the method is commented within the function: |
|
I've mistaken the native/Juce menu bar option with the alert windows option ( ctrlrNativeFileDialogs) and the one for the fileChooser. It means that we can just add a statement from a macro for Linux vs other os for this help window menubar style. |
|
I did not check the way you implemented your statement for if_linux and wayland if you do it at the preprocessor level with a macro, we can also use a mixture of both macros and |
|
Hi John, I just tried your latest version https://github.com/dnaldoog/CtrlrX/tree/refs/heads/5.6.35-Maintenance_formatHelp It's really good and the icon colours are following the lnf. The help title bar are still the JUCE one we would need to have the native OS one except for LINUX wayland since it's the only system having a problem. I'll slowly include all your mods next week on my repo and will work on the Wiki page to provide a robust help structure. Thanks a lot!
|
|
Great! Will look at that. I also created a help file for people to understand hex numbers and MIDI with its 7 bit limitation. It’s really for beginners, but I think it’s really good to give support for people who are just getting started with creating panels. I was trying to think of a simple general help system for lua and CtrlrX, but it’s quite difficult to think where to start, because of course it gets pretty deep pretty quickly and then I thought, why not list a few useful tips like how to block midi;how to get the channel out; how to generate VST index; how to loop through all modulators; how to block functions on start - all that sort of thing - just a few general useful routines that people might find useful. |
|
I think the best we can start is with a contextual help. |
|
I have just created another couple of help files; one is for saving files and another one for common lua code operations. I think it is already really helpful, but if you want to go the full hog, yes you will need some form of online reference, but I think right now as it stands, it’s very useful - will upload a build very soon. Or the other thing could be you use Dominique’s already excellent guide. But for a quick reference, I think having a few help pages on the app is quite useful for quick reference. |
|
Please check the Action build! Incidentally there is already Wayland detection code here as a static function , but I haven't used it yet.
|
|
Hi John, I just checked and the native bars are showing for macos. Thank for all the work you've done. |
|
Great - did you try resizing the windows? There's some weirdness but I have fixed it in the latest commit. Shall I do a PR? Do you want to keep those help files in CrtrlrX or move them out or have both in the app and on a Wiki page? |
|
I don't know yet for the pages if we should go local or distant with a webcomponentwindow. |
|
This is the branch. |







This updates the Multi Midi section with new code and a help section.
ids::midiMessageCtrlrValuechanging vlaue seems to do nothing - not sure what it does internally but left as isids::midiMessageCtrlrNumberSize