Conversation
|
By the way, this should fix issue #8 |
|
That's awesome! Thanks for the PR, I'll add it manually to 5.6.32 and the Master branch. I'm not a LINUX user, so I rely 100% on you ;) Thanks for your help Hedde! Damien |
|
There was a lot of files updated for LINUX a long time ago I did not merged to CtrlrX yet. I was wondering if CtrlrX was working properly on your LINUX install or it required some other updates? Let me know, thanks Damien |
|
I'll close the PR because I merged it by hand since Xcode can't see any changes in the Builds/Linux/ folder that is not synced up. But it's already on CtrlrX Master and 5.6.32. |
I saw that issue+PR also indeed. It ditched the Makefile for CMake (which may be a wise choice for the future as JUCE also builds with it nowadays), and a whole lot of LUA changes. To my surprise I didn't need any source code changes on my machine (it has liblua5.2 and liblua5.4 installed I see). I've only tested CtrlrX with 1 panel so far, and that worked... I'll test a bit more over time and if I find anything I'll post an issue or PR. I was wondering if you have any GitHub actions to automatically compile & package for different platforms and configs. If so, you could add a Linux build (I see you can choose specific distro versions for example) and see if that works. That may also give good automated feedback for future changes. Cheers, H |
|
Hi, I never used a CI/CD pipeline, I guess setting up a platform with github from the projucer makefile would be the easy way. I'll give it a try with GitHub Actions when I'll get free time. If you think you can help with the appropriate settings to compile for LINUX, let me know. |
|
To be honest I also don't have experience setting up a CI/CD pipeline, but I'm interested to help out (but with limited time available). You can find my email address via my commits. I know there's examples out there we can learn from (GitHub supplies nice examples, and for example from Surge XT, probably many more to find). And the 'runners' do support macOS intel and ARM it seems (see docs) It looks like this script was actually meant for CI/CD: https://github.com/damiensellier/CtrlrX/blob/master/Scripts/post-commit . It does run and package CtrlrX on my PC, so that may be a good start? |
* FIX LINUX MAKEFILE from @sgorpi PR damiensellier#84
* FIX LINUX MAKEFILE from @sgorpi PR damiensellier#84
Thx for making Ctrl up to date @damiensellier !
To compile on Ubuntu 24.04 I had to fix a few minor issues in the makefile:
For reference, I had to install the following packages (maybe more are needed but I had those installed on my system already):
With that it compiles and runs.