Merged
Conversation
Owner
|
@mariusbarth That's great, thanks a lot! A plot of estimated correlations is certainly useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @danheck,
This PR adds support for for posterior predictive standard deviation (
stat = "sd") and correlation (stat = "cor") plots inplotFit().I implemented these additional plots because the covariance plots can quickly become unwieldy, and I observed, in some use cases, that these plots were dominated by variances (making co-variances hard to discriminate from zero).
(I think) I also fixed the placement of separator lines for covariance plots. Here is the new behavior, where the lines separate each column of the lower triangle of the covariance matrix.
I could not make sense of the old behavior here:
There is also a tiny change in
PPP.R. This change is unrelated, but harmless. It does the same as the old function, but is faster (magnitude 2x). If you want to go one step further, you could useasplit(), but this comes with a dependency (R>=4.1.0).If you have any questions or suggestions, feel free to ask.
Best,
Marius