Inplement ignorePaths and requiredPaths settings#152
Inplement ignorePaths and requiredPaths settings#152danielflower merged 4 commits intodanielflower:masterfrom
Conversation
nut-3
force-pushed
the
inplement-ignore-and-required-paths
branch
from
f6e6fd6 to
23ce509
Compare
danielflower
left a comment
danielflower
left a comment
There was a problem hiding this comment.
Thanks - looks good overall. I only have a couple of small comments on the documentation. Get that done and I'll get it merged.
|
|
||
| /** | ||
| * <p>List of file system paths that are required to be changed when detecting changes in the project(s).</p> | ||
| * <p>The primary purpose is to trigger creating new releases only f certain changes occur in the repository. |
There was a problem hiding this comment.
Small typo: "...only f certain..."
I presume this is optional and if not set any file will cause it - can you spell this out at/near the top of this comment block?
There was a problem hiding this comment.
Fixed typos and added clarification about the default behavior in the JavaDoc.
| ----------------------------------------------------------- | ||
|
|
||
| The primary purpose is to trigger creating new releases only f certain changes occur in the repository. | ||
| For example, a library repository with ProtoBuf messages would trigger release only if any of the *.proto files has been modified. |
There was a problem hiding this comment.
Could you specify what wildcards are or aren't allowed - e.g. is it regex, glob patterns, or something else. And in the example exclude *.proto so it's obvious how to do that.
There was a problem hiding this comment.
I've added clarification on how the plugin works if the option is not set and an explanation of the path matching logic. If something could be improved further, please give me a notice.
nut-3
force-pushed
the
inplement-ignore-and-required-paths
branch
from
f23eeba to
931c90b
Compare
|
Thanks, this has been released in |
3 participants
This PR addresses #77 and enables releases to be triggered only with certain file changes.