Skip to content

Conversation

@TacoTheDank
Copy link

@TacoTheDank TacoTheDank commented Jun 16, 2022

1st commit

  • Delete unnecessary .idea files

2nd commit

  • Update gradle and its wrapper to 7.4.2 using Git Bash

3rd commit

  • Delete unused example tests

4th commit

  • Fix deprecations in submodule build.gradle
  • Use new DSL block for plugins
  • Specify using Java 11 (just a technicality)
  • Remove unused deprecated jcenter
  • Update AGP 7.2.0 -> 7.2.1
  • Remove unneeded Jetifier option in gradle.properties (everything already uses AndroidX)
  • Remove unused Material library (this shrinks the app)

5th commit

  • Utilize AndroidX Core parseAsHtml KTX extension (does version code check internally)
  • Migrate to using Activity Result API
  • Utilize ContextCompat.startForegroundService (does check internally)
  • Clean up preference screen attributes
  • Use FragmentContainerView (as recommended by AndroidX)
  • Utilize app:iconSpaceReserved="false" (fixes large padding on left side of preferences, makes them look nicer)

6th commit

  • Replace platform drawables (old and ugly) with Material Icons (nice)
  • Renamed ic_notification to ic_surround_sound, as this is the proper name for this drawable

7th commit

  • I used Audacity to cut the audio time to 5 seconds, changed the encoding to an unsigned 8-bit PCM (from a signed 16-bit PCM), and reduced the Hz to 16,000 (from 48,000 Hz). This drastically shrinks the file size from 2.74 MB to 156 KB.

8th commit

  • Enable minification without obfuscation (this shrinks the app size by a ton)

9th commit

  • Migrate to using ViewBinding

10th commit


Feel free to ask any questions you might have.

@danielgjackson
Copy link
Owner

Hi @TacoTheDank, thanks for all this work -- somehow, I've only just noticed the pull request! I should get round to looking at it properly soon. Cheers.

@TacoTheDank
Copy link
Author

@danielgjackson It's been a while. Any updates?

@BenjaminBrienen
Copy link

@danielgjackson ???

@BenjaminBrienen
Copy link

@TacoTheDank Would you be willing to publish your fork on F-Droid? I really need this app but it barely works on my Pixel 7 Pro.

@eproffitt
Copy link

@TacoTheDank can you merge to your own master branch (without deleting your patch branch, of course) and build the apk? Or, as @BenjaminBrienen said, publish your fork to F-Droid? Giving proper attribution, as is only right.

@eproffitt
Copy link

eproffitt commented Dec 17, 2024

@danielgjackson are you good with merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants