This repository was archived by the owner on Jan 7, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Reorganize episodes and podcasts views into focused modules #391
Draft
Copilot
wants to merge
43
commits into
main
Choose a base branch
from
copilot/reorganize-episodes-and-podcasts-views
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
…y to cookie_banner.py (#360) * Initial plan * Move title_tag and meta_tags from page_layout.py to head_tags.py Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Rename page_layout.py to cookie_banner.py and update all template references Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * fix: precommit fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
* Initial plan * Rename audio_player.py to player.py and update all references Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * fix: precommit fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
…on (#364) * Initial plan * Create merged templatetags.py and update all template files Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Remove old templatetags directory and update imports Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Add templatetags to TEMPLATES builtins and remove load statements Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Remove section separator comments from templatetags.py Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * fix: precommit fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
* Initial plan * Move search functions and update all URL references Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Remove moved functions from views/search.py and urls/search.py Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Update search_people.html to use new podcast search URL Co-authored-by: danjac <249779+danjac@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
* Initial plan * Merge all middleware modules into single middleware.py file Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Delete old middleware directory Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Fix import in test_templatetags.py for middleware module Co-authored-by: danjac <249779+danjac@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac@users.noreply.github.com>
* Initial plan * Move search_people view to views/podcasts and update all references Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * fix: test fixes * fix: test fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
* Initial plan * Merge views and URLs for history and bookmarks into episodes Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * fix: test fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* Initial plan * Merge test_history.py and test_bookmarks.py into test_episodes.py Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Fix duplicate assertion and pytest marker syntax Co-authored-by: danjac <249779+danjac@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
* Initial plan * Merge player views, URLs, and tests into episodes module Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Remove old player module files Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Update templatetags import to use episodes module Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Resolve merge conflict in test_episodes.py Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Merge main branch into player merge branch Properly merge the main branch which consolidated episode-related tests into test_episodes.py. This resolves the merge conflict by combining all test classes from both branches. Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Fix pytest marker syntax error in test_episodes.py Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * fix: test fixes * refactor: tidy up views --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
* Initial plan * Merge subscriptions into podcasts module Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Move private function to end of module Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * refactor: tidy up views --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com> Co-authored-by: Dan Jacob <danjac2018@gmail.com>
* Initial plan * Move private feeds functionality to podcasts module Co-authored-by: danjac <249779+danjac@users.noreply.github.com> * Delete old private_feeds files Co-authored-by: danjac <249779+danjac@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
* Initial plan * Merge categories functionality into podcasts module - Merged views from views/categories.py into views/podcasts.py - Merged URLs from urls/categories.py into urls/podcasts.py - Updated URL references (categories:index -> podcasts:categories, categories:detail -> podcasts:category_detail) - Updated Category model's get_absolute_url method - Merged tests from test_categories.py into test_podcasts.py - Moved templates to podcasts directory - Removed old categories files and references Co-authored-by: danjac <249779+danjac@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Co-authored-by: danjac <249779+danjac@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Reorganize episodes and podcasts views for better structure
Reorganize episodes and podcasts views into focused modules
Jan 7, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The episodes and podcasts views had grown into monolithic files mixing distinct concerns (bookmarks, history, player controls, subscriptions, private feeds). This reorganizes them into focused modules aligned with feature boundaries.
Episodes Split
bookmarks(),add_bookmark(),remove_bookmark()history(),mark_complete(),remove_audio_log()start_player(),close_player(),player_time_update()index(),episode_detail(),search_episodes()Podcasts Split
subscriptions(),subscribe(),unsubscribe()private_feeds(),add_private_feed(),remove_private_feed()discover(),podcast_detail(),latest_episode(),episodes(),season(),similar(), search views, category viewsStructure
Each module consists of:
simplecasts/views/{module}.py- view functionssimplecasts/urls/{module}.py- URL patterns with dedicated app_name namespacesimplecasts/tests/views/test_{module}.py- test classesExample URL namespace change:
All URL patterns and view signatures remain unchanged for backward compatibility.
Files changed: 22 files (7 views, 7 URLs, 7 tests, 1 main URL config)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.