forked from mickle00/force-navigator
-
Notifications
You must be signed in to change notification settings - Fork 6
use URL class to get the host instead of regex parsing #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Damecek
wants to merge
17
commits into
dannysummerlin:master
Choose a base branch
from
Damecek:fix/TypeError-url-parsing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrap around `forceNavigator.getHTTP` and gather similar params under same method
…url if existing, default to SObject name
(cherry picked from commit b5ee374)
Those should not be processed, for some reason those adds to stack for processing on setup pages. (cherry picked from commit 865736e)
(cherry picked from commit dae2129)
(cherry picked from commit 01764d3)
getting the cookies from this urls needs to have declared permission
this effectively avoids this error: Uncaught (in promise) TypeError: Cannot read properties of null (reading '1') serviceWorker.js:1 (anonymous function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this effectively avoids this error:
Uncaught (in promise) TypeError: Cannot read properties of null (reading '1')
serviceWorker.js:1 (anonymous function)