Skip to content

Add plugin : upgrade planet automatically #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
goldenfiredo wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add plugin : upgrade planet automatically #183

goldenfiredo wants to merge 5 commits into from

Conversation

@goldenfiredo
Copy link

@goldenfiredo goldenfiredo commented Oct 15, 2021

No description provided.

@goldenfiredo goldenfiredo changed the title Add plugin : upgrate planet automatically Add plugin : upgrade planet automatically Oct 16, 2021
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Copy link
Contributor

@Stx69 Stx69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I did some trial- Sending of silver work well, but I miss some option for upgrade without interaction of code..

Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
Stx69
Stx69 reviewed Oct 17, 2021
View reviewed changes
@goldenfiredo
Copy link
Author

goldenfiredo commented Oct 18, 2021 •
edited
Loading

Hi, I did some trial- Sending of silver work well, but I miss some option for upgrade without interaction of code..

Hi Stx69,
I implement the plugin upgrade automatically without the user specifying pattern. When the selected planet got enough silver (=silverCap), upgrading thread will upgrade planet step by step till it reach max rank. If silver used out but planet hadn't upgraded to max rank, the sending-silver thread will send silver again. I did the testing, the code can work well. If you have not been able to upgrade automatically let me know.
Thanks,

@Stx69
Copy link
Contributor

Stx69 commented Oct 18, 2021

At default state provided code only upgrades for max. defense rank and if is possible one range. Please give the user option how will be upgrade ranks looks..

Stx69
Stx69 previously approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@Stx69 Stx69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, yeap 👍 , now user is able to decide.. I have a last coment... Please think about size of window for plugin.. Whta about planet name for example?

Stx69
Stx69 previously approved these changes Dec 6, 2021
View reviewed changes
@ichub
Copy link
Member

ichub commented Mar 29, 2022

@goldenfiredo - did you still want to get this plugin into the showcase?

@cristobal
Copy link
Contributor

cristobal commented Mar 31, 2022

@goldenfiredo this is actually two plugins in one PR, could you split it up please and have on PR for each of them thanks 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Stx69 Stx69 Stx69 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goldenfiredo @Stx69 @ichub @cristobal