Always quit with the correct exit code#44
Closed
addaleax wants to merge 1 commit intodarkguy2008:masterfrom
Closed
Always quit with the correct exit code#44addaleax wants to merge 1 commit intodarkguy2008:masterfrom
addaleax wants to merge 1 commit intodarkguy2008:masterfrom
Conversation
Quit with the exit code of the first failing child, even if the other children exit very fast after the failing child.
Collaborator
|
Hey @addaleax thanks for the PR. Looking at the code, I think we already do exit if the code > 0, also I think this may break the |
Collaborator
|
I think I'll close this. Thanks very much for the PR though. If you feel like helping out, once we close mysticatea/npm-run-all#10 I'll deprecate this repo and we would absolutely love to see you over in http://github.com/mysticatea/npm-run-all raising issues and making PRs 😄 |
Author
|
Okay, thanks for the info! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quit with the exit code of the first failing child, even if the other children exit very fast after the failing child.
Output with the current master:
This patch changes the output code to 1. If you have a better solution and/or understanding of the problem, feel free to discard this PR, but the underlying issue is real.