Memoize3 by darkleaf · Pull Request #45 · darkleaf/di

darkleaf · 2025-03-29T18:43:01Z

closes #36

src/darkleaf/di/core.clj

darkleaf · 2025-04-02T08:18:04Z

test/darkleaf/di/tutorial/z_memoize_test.clj.back

@@ -0,0 +1,54 @@
+(ns darkleaf.di.tutorial.z-memoize-test ;;todo: name


Тут предполагается написать тест-документацию.

А тест выше - технический.

Можно по идее технический тест сюда положить.

лучше наш реальный юзкейс сюда

src/darkleaf/di/core.clj

test/darkleaf/di/memoize_test.clj

darkleaf · 2025-04-03T12:23:48Z

src/darkleaf/di/core.clj

+                    p/description
+                    ;; хз надо ли так
+                    ;; у нас тут нет способа понять уже закешировано или только сейчас
+                    #_(assoc ::memoized true))))))))))


will-be-memoized

KGOH · 2025-04-03T12:50:20Z

src/darkleaf/di/core.clj

+
+(defn ->memoize
+  "Returns a statefull middleware that memoizes all registry build accesses.
+  Must be the last in a middleware chain.


memoizes all components before itself and doesn't affect the ones after it

Не согласуется с предыдущим предложением.

надо подумать.

src/darkleaf/di/core.clj

darkleaf · 2025-04-16T09:37:05Z

src/darkleaf/di/core.clj

+      (apply [_ previous-registry]
+        (when-not (-> previous-registry meta ::idx zero?)
+          (throw (ex-info "memoize should be first" {})))
+        (let [registry    (apply-middlewares previous-registry middlewares 0)]


это будет вычисляться на каждый di/start, наверное это не является проблемой?

darkleaf · 2025-04-16T19:27:25Z

src/darkleaf/di/core.clj

+      Function
+      (apply [_ previous-registry]
+        (when-not (-> previous-registry meta ::idx zero?)
+          (throw (ex-info "memoize should be first" {})))


darkleaf · 2025-04-16T19:32:50Z

test/darkleaf/di/memoize_test.clj

+    (-> (di/start `a mem)
+        (di/stop))
+    (t/is (= [[:start ::param]
+              [:start `a]
+              [:start ::di/implicit-root]]
+             @log))))


может быть этот кусочек отдельным тестом?
тут проверяется, что .close на мапе вызывается

src/darkleaf/di/core.clj

darkleaf · 2025-04-23T10:17:33Z

src/darkleaf/di/core.clj

+      (apply [_ previous-registry]
+        (when-not (-> previous-registry meta ::idx zero?)
+          (throw (ex-info "memoize should be first" {})))
+        (let [registry (apply-middlewares previous-registry middlewares 0)]


это должно происходить уровнем выше. чтобы этого добиться нужно выпилить/переделать implicit-root. чтобы implicit-root не было в реестре, и чтобы цепочка реестров не зависила от ключа.

это позволит делать проверку реестров по identical?

нужно кэшировать фабрики, их инстанцирование занимает много времени

функа в computeIfAbsent должна использовать ключ, а не замыкания

darkleaf · 2025-04-25T04:53:58Z

src/darkleaf/di/core.clj

+        (when-not (identical? previous-registry initial-registry)
+          (throw (ex-info "memoize should be first" {})))
+        (fn [key]
+          (let [factory #_(registry key)  (.computeIfAbsent factories key registry)]


darkleaf · 2025-04-25T07:47:41Z

src/darkleaf/di/core.clj

+                    (concat (seq (p/dependencies factory))
+                            (seq {::side-dependency :optional})))


will-be-memoized refactor test fix clear idea test fix .clear test refactoring fix test add profiler idea 2 next save fix

darkleaf · 2025-04-25T14:18:53Z

closed by #54

darkleaf changed the base branch from master to memoize2 March 29, 2025 18:43

darkleaf changed the base branch from memoize2 to master March 30, 2025 16:20

darkleaf force-pushed the memoize3 branch from 87d8e82 to d418437 Compare March 30, 2025 16:27

darkleaf commented Mar 31, 2025

View reviewed changes

src/darkleaf/di/core.clj Outdated Show resolved Hide resolved

darkleaf force-pushed the memoize3 branch 3 times, most recently from b548443 to 3289bae Compare April 2, 2025 07:43

darkleaf commented Apr 2, 2025

View reviewed changes

krevedkokun requested changes Apr 2, 2025

View reviewed changes

src/darkleaf/di/core.clj Outdated Show resolved Hide resolved

KGOH reviewed Apr 2, 2025

View reviewed changes

src/darkleaf/di/core.clj Show resolved Hide resolved

darkleaf commented Apr 2, 2025

View reviewed changes

src/darkleaf/di/core.clj Outdated Show resolved Hide resolved

darkleaf commented Apr 3, 2025

View reviewed changes

test/darkleaf/di/memoize_test.clj Outdated Show resolved Hide resolved

darkleaf commented Apr 3, 2025

View reviewed changes

KGOH reviewed Apr 3, 2025

View reviewed changes

darkleaf force-pushed the memoize3 branch 3 times, most recently from fe5b8d1 to 7635db8 Compare April 3, 2025 15:38

darkleaf commented Apr 3, 2025

View reviewed changes

src/darkleaf/di/core.clj Outdated Show resolved Hide resolved

darkleaf commented Apr 16, 2025

View reviewed changes

darkleaf force-pushed the memoize3 branch from 7db810e to 632a6b8 Compare April 16, 2025 16:59

darkleaf commented Apr 16, 2025

View reviewed changes

darkleaf force-pushed the memoize3 branch from ad69c3d to dec84f5 Compare April 16, 2025 19:31

darkleaf commented Apr 16, 2025

View reviewed changes

src/darkleaf/di/core.clj Outdated Show resolved Hide resolved

darkleaf commented Apr 23, 2025

View reviewed changes

darkleaf force-pushed the memoize3 branch 3 times, most recently from 5876981 to e5f602f Compare April 25, 2025 04:42

darkleaf commented Apr 25, 2025

View reviewed changes

memoize

99ae3c1

will-be-memoized refactor test fix clear idea test fix .clear test refactoring fix test add profiler idea 2 next save fix

darkleaf force-pushed the memoize3 branch from ba710c9 to 99ae3c1 Compare April 25, 2025 12:44

darkleaf closed this Apr 25, 2025

darkleaf deleted the memoize3 branch April 25, 2025 14:20

		@@ -0,0 +1,54 @@
		(ns darkleaf.di.tutorial.z-memoize-test ;;todo: name

		(concat (seq (p/dependencies factory))
		(seq {::side-dependency :optional})))

Conversation

darkleaf commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

darkleaf Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darkleaf Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darkleaf commented Apr 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

darkleaf commented Mar 29, 2025 •

edited

Loading

darkleaf Apr 3, 2025 •

edited

Loading

darkleaf Apr 23, 2025 •

edited

Loading