Update dart_mcp to spec version 2025-11-25#357
Merged
jakemac53 merged 12 commits intodart-lang:mainfrom Feb 25, 2026
Merged
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
| required String elicitationId, | ||
| Meta? meta, | ||
| }) => ElicitationCompleteNotification.fromMap({ | ||
| 'elicitationId': elicitationId, |
Contributor
There was a problem hiding this comment.
are we using raw strings here because AI tooling is authoring these specs? Perhaps we could the agent via skills to use consts instead of raw strings to adhere to best practices?
Contributor
Author
There was a problem hiding this comment.
Probably if we just did a single cleanup to replace these all with constants, then in the future it would use constants.
It is a mixture of AI/Hand coded stuff (but even the hand coded stuff, I just go with the existing pattern here which has been raw strings). But it would be good to avoid any typos by using the constants.
kenzieschmoll
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This does not implement Task support, which is still experimental. It would be a fair bit of implementation work and should be done in a separate PR if we choose to implement it. But I think we should wait until it is non-experimental anyways.
This ended up being fairly complex, but it's not as bad as it looks, as much of the changes are to examples and tests.
See the CHANGELOG.md for a full description of the changes, some highlights:
UrlElicitationRequirederrors in tool calls.ToolChoicesupport for sampling