fix: canonicalize paths in _analyzeFiles to match diagnostic URIs#358
Open
reza-codes wants to merge 1 commit intodart-lang:mainfrom
Open
fix: canonicalize paths in _analyzeFiles to match diagnostic URIs#358reza-codes wants to merge 1 commit intodart-lang:mainfrom
reza-codes wants to merge 1 commit intodart-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295
The diagnostic URIs from the LSP server and the URIs built via
rootUri.resolve(path)can differ on systems with symlinks(e.g., macOS /var → /private/var). This causes the path filter in_analyzeFilesto match zero entries, returning false "No errors".Apply
fileSystem.path.canonicalize()to both paths before comparison,matching the pattern already used by
isUnderRootincli_utils.dart.