feat: add Process.set_label/1 to Broadway stages#363
Merged
josevalim merged 1 commit intodashbitco:mainfrom Oct 1, 2025
Merged
feat: add Process.set_label/1 to Broadway stages#363josevalim merged 1 commit intodashbitco:mainfrom
josevalim merged 1 commit intodashbitco:mainfrom
Conversation
yordis
force-pushed
the
yordis/fixes-353
branch
2 times, most recently
from
cebc1d8 to
690ff30
Compare
Member
|
Thank you! We will need to bump the Elixir requirement to v1.17, which seems quite steep. We should probably do a function_exported? check before. |
Pull Request Test Coverage Report for Build 40ef5c67c0f53a584e7e2b0d9916398bd95bf662-PR-363Details
💛 - Coveralls |
yordis
force-pushed
the
yordis/fixes-353
branch
4 times, most recently
from
6326b67 to
1983a52
Compare
yordis
commented
Oct 1, 2025
Comment on lines
4
to
15
| # TODO: Remove this module once we require Elixir 1.17+. | ||
| # Process.set_label/1 was added in Elixir 1.17.0. | ||
|
|
||
| if function_exported?(Process, :set_label, 1) do | ||
| def set_label(label) do | ||
| Process.set_label(label) | ||
| end | ||
| else | ||
| def set_label(_label) do | ||
| :ok | ||
| end | ||
| end |
Contributor
Author
There was a problem hiding this comment.
if you prefer another way, let me know
yordis
force-pushed
the
yordis/fixes-353
branch
from
1983a52 to
d8aa7bc
Compare
yordis
commented
Oct 1, 2025
yordis
force-pushed
the
yordis/fixes-353
branch
2 times, most recently
from
733bf0d to
c2dbc20
Compare
Contributor
Author
|
@josevalim ready to CR |
fixes dashbitco#353 Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fixes-353
branch
from
c2dbc20 to
40ef5c6
Compare
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #353
Signed-off-by: Yordis Prieto yordis.prieto@gmail.com