Skip to content

Update broadway.ex#366

Open
VigneshwaranSenthilvel wants to merge 3 commits intodashbitco:mainfrom
VigneshwaranSenthilvel:patch-1
Open

Update broadway.ex#366
VigneshwaranSenthilvel wants to merge 3 commits intodashbitco:mainfrom
VigneshwaranSenthilvel:patch-1

Conversation

@VigneshwaranSenthilvel
Copy link

Testing with a specific handle_batch

@josevalim
Copy link
Member

Can you please update the docs and tests?

@josevalim
Copy link
Member

Thank you. Although the docs are a bit too thin on the details. Isn't the code in handle_message most likely going to select a batch anyway, overriding this choice? So when would using this option be practical?

PS: also please run mix format.

whatyouhide
whatyouhide previously approved these changes Jan 30, 2026
@whatyouhide whatyouhide dismissed their stale review January 30, 2026 10:51

Mistaken!

@whatyouhide
Copy link
Collaborator

Also, missing an annotation on "Available since ..." or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments