Fix ignoring schema when wildcard-key is defined#142
Merged
whatyouhide merged 1 commit intodashbitco:mainfrom Apr 5, 2025
Merged
Fix ignoring schema when wildcard-key is defined#142whatyouhide merged 1 commit intodashbitco:mainfrom
whatyouhide merged 1 commit intodashbitco:mainfrom
Conversation
Member
|
Yeah, I feel it should be [table: nil] for both, right @whatyouhide? |
Pull Request Test Coverage Report for Build e7ed4c95ea219a988286bc04378fe70620abab1a-PR-142Details
💛 - Coveralls |
whatyouhide
approved these changes
Apr 5, 2025
Collaborator
whatyouhide
left a comment
There was a problem hiding this comment.
Yes I think this is a great change, I'd consider it a bug fix 🙃 Thank you @florius0 💟
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, schemas with wildcard-key defined misbehave:
The reason is that
NimbleOptions.expand_star_to_option_keys/2ignores all other keys, except present in the data when handling wildcard.Is that intended?