You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @Matt711!
Would you mind if I try whether things still work with the Flytedask plugin (this thing) once you're ready?
It makes some assumptions around the job here, in particular the job-runner pod name, etc. So would be nice if this wouldn't be breaking the plugin
Hey @Matt711! Would you mind if I try whether things still work with the Flytedask plugin (this thing) once you're ready? It makes some assumptions around the job here, in particular the job-runner pod name, etc. So would be nice if this wouldn't be breaking the plugin
The reason will be displayed to describe this comment to others. Learn more.
I think we probably want our spec to replace this, rather than the "spec" within "template".
That does mean we need to modify our CRDs to ref a JobSpec instead. That is a breaking change to our CRDs so we might need to think about how to bump the version there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #695. This PR replaces the Pod created from a DaskJob CRD with a Job. This allows us to use some of the existing functionality of K8s Jobs.