Conversation
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thats for being patient for review here. From what I have read of the code the logic makes sense.
Do you have any thoughts about how we could test this? Have you been running this in a real world setting?
|
I believe #877 has implemented the same logic in this PR.
I've been running this PR on a 300 worker cluster for a somewhile and it worked effortlessly.
Unfortunately, No since I'm not familiar with dask's test suites. but generally a test should launch a n of unschedulable workers and wait for the controller to downscale them to the correct number. |
|
I just bumped this PR to use the latest code from |
Based on discussion at #817