Patch long lived DaskCluster components on update#936
Draft
edgar-s-silva-alb wants to merge 1 commit intodask:mainfrom
Draft
Patch long lived DaskCluster components on update#936edgar-s-silva-alb wants to merge 1 commit intodask:mainfrom
edgar-s-silva-alb wants to merge 1 commit intodask:mainfrom
Conversation
Author
|
@jacobtomlinson Hey, from my testing this solution is not currently working fully, but does work on some cases with the scheduler. |
edgar-s-silva-alb
force-pushed
the
operator-cluster-update
branch
from
2824d76 to
8a51e23
Compare
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
This approach generally looks reasonable to me. Feel free to ping me for full review when ready.
Could you make sure you're running pre-commit to fix up linting issues. It looks like your editor has changed a bunch of things that are formatting related.
Comment on lines
+392
to
+393
| assert name | ||
| assert namespace |
Member
There was a problem hiding this comment.
If either of these assertions fail then kopf will retry automatically forever. We probably need to catch the assertion error and just return if this isn't what we want to hapen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #895.
I'm not super familiar with kopf and kubernetes code in general, so some input would be appreciated.