Skip to content

fix: Stop lumino polling for clusters when connection is lost#275

Merged
jacobtomlinson merged 1 commit intodask:mainfrom
mahendrapaipuri:fix_lumino_polling
Jun 2, 2025
Merged

fix: Stop lumino polling for clusters when connection is lost#275
jacobtomlinson merged 1 commit intodask:mainfrom
mahendrapaipuri:fix_lumino_polling

Conversation

@mahendrapaipuri
Copy link
Contributor

  • Currently lumino polls for available clusters with a given frequency. However, when the server terminates, the polling does not stop as long as the browser tab is active. This is an issue in JupyterHub deployments where terminated servers keep making requests to hub when the browser tabs are kept open. This is undesirable as hub still needs to respond to these requests although they end up with 424.
  • More background on JupyterLab #17567

@jacobtomlinson @ian-r-rose Could you please take a look at it? Also should we drop support for Python 3.8 and add support for 3.12 and 3.13 which will be inline with JupyterLab? Cheers!!

@mahendrapaipuri
Copy link
Contributor Author

I think the failed CI workflow is due to hatch not supporting 3.8

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little out of my depth with the changes here, but overall it makes sense. If you've tested it and can confirm that the desired functionality has been fixed then I'm happy to merge this.

Also yes I agree we should bump up our CI versions here.

* Currently lumino polls for available clusters with a given frequency. However, when the server terminates, the polling does not stop. This is relevant in JupyterHub deployments where terminated servers keep making requests to hub when the browser tabs are kept open. This is undesirable as hub still needs to respond to these requests although they end up with 424.

Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
@mahendrapaipuri
Copy link
Contributor Author

I'm a little out of my depth with the changes here, but overall it makes sense. If you've tested it and can confirm that the desired functionality has been fixed then I'm happy to merge this.

Fair enough. As I included in the PR description, we did the same fix for few extensions on the upstream JupyterLab. Yes, I have tested it with JupyuterHub and I confirm that the browser puts polling in stand-by once connection to the single user server is lost.

I have rebased the branch onto the main with #276

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated

@jacobtomlinson jacobtomlinson merged commit 0264df0 into dask:main Jun 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants