fix: Stop lumino polling for clusters when connection is lost#275
fix: Stop lumino polling for clusters when connection is lost#275jacobtomlinson merged 1 commit intodask:mainfrom
Conversation
|
I think the failed CI workflow is due to |
jacobtomlinson
left a comment
There was a problem hiding this comment.
I'm a little out of my depth with the changes here, but overall it makes sense. If you've tested it and can confirm that the desired functionality has been fixed then I'm happy to merge this.
Also yes I agree we should bump up our CI versions here.
* Currently lumino polls for available clusters with a given frequency. However, when the server terminates, the polling does not stop. This is relevant in JupyterHub deployments where terminated servers keep making requests to hub when the browser tabs are kept open. This is undesirable as hub still needs to respond to these requests although they end up with 424. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
d447928 to
1f2ef0f
Compare
Fair enough. As I included in the PR description, we did the same fix for few extensions on the upstream JupyterLab. Yes, I have tested it with JupyuterHub and I confirm that the browser puts polling in stand-by once connection to the single user server is lost. I have rebased the branch onto the main with #276 |
@jacobtomlinson @ian-r-rose Could you please take a look at it? Also should we drop support for Python 3.8 and add support for 3.12 and 3.13 which will be inline with JupyterLab? Cheers!!