Appkit cli commands #4247
Draft
Appkit cli commands #4247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
2 times, most recently
from
398f5f2 to
04f4c88
Compare
chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup chore: fixup
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
04f4c88 to
6e23dec
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: f0b22d5
28 interesting tests: 17 RECOVERED, 6 KNOWN, 4 flaky, 1 SKIP
Top 48 slowest tests (at least 2 minutes):
|
fjakobs
requested changes
Jan 14, 2026
| } | ||
|
|
||
| // downloadDirectory recursively downloads all files from a workspace path to a local directory. | ||
| func downloadDirectory(ctx context.Context, w *databricks.WorkspaceClient, remotePath, localDir string, force bool) (int, error) { |
Contributor
There was a problem hiding this comment.
You should use generate.NewDownloader to re-use the existing file download code
| } | ||
|
|
||
| // Step 5: Run npm install if package.json exists | ||
| packageJSONPath := filepath.Join(destDir, "package.json") |
Contributor
There was a problem hiding this comment.
We should do another pass over the import command. I'd like to always create a bundle and then also make sure we bind the resources properly. That's something we could do in a follow up.
| <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" /> | ||
| <link rel="manifest" href="/site.webmanifest" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Created by Apps MCP</title> |
Contributor
There was a problem hiding this comment.
Suggested change
| <title>Created by Apps MCP</title> | |
| <title>Created by Databricks AI Tools</title> |
experimental/apps-mcp/templates/appkit/generic/databricks.yml.tmpl
Outdated
Show resolved
Hide resolved
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func New() *cobra.Command { |
Contributor
There was a problem hiding this comment.
can we drop the dev for now so iso databricks experimental dev apps ... we use databricks experimental apps ...?
It's already pretty long.
|
|
||
| // Step 1: Build frontend (unless skipped) | ||
| if !skipBuild { | ||
| if err := runNpmTypegen(ctx); err != nil { |
Contributor
There was a problem hiding this comment.
running typegen make sense but only if it is a node.js app and we have a package.json
| log.Infof(ctx, "Running app: %s", appKey) | ||
| if err := runApp(ctx, b, appKey); err != nil { | ||
| cmdio.LogString(ctx, "✔ Deployment succeeded, but failed to start app") | ||
| return fmt.Errorf("failed to run app: %w", err) |
Contributor
There was a problem hiding this comment.
We should print a message telling the user to run databricks apps logs to debug this.
| var output syncBuffer | ||
|
|
||
| err := RunWithSpinnerCtx(ctx, "Generating types...", func() error { | ||
| cmd := exec.CommandContext(ctx, "npm", "run", "typegen") |
Contributor
There was a problem hiding this comment.
Suggested change
| cmd := exec.CommandContext(ctx, "npm", "run", "typegen") | |
| cmd := exec.CommandContext(ctx, "npm", "run", "typegen", "--if-present") |
| var output syncBuffer | ||
|
|
||
| err := RunWithSpinnerCtx(ctx, "Building frontend...", func() error { | ||
| cmd := exec.CommandContext(ctx, "npm", "run", "build") |
Contributor
There was a problem hiding this comment.
Suggested change
| cmd := exec.CommandContext(ctx, "npm", "run", "build") | |
| cmd := exec.CommandContext(ctx, "npm", "run", "build", "--if-present") |
| @@ -0,0 +1,419 @@ | |||
| package app | |||
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
appkit-cli-commands
branch
from
d552cd0 to
f0b22d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests