Skip node_modules when downloading app source code #4274
Merged
+86
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Add custom recursive listing to bundle generate app that skips node_modules directories entirely, avoiding unnecessary API calls and file downloads for large dependency folders. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
fjakobs
force-pushed
the
skip-node-modules-in-bundle-generate
branch
from
269e64d to
00c9bd9
Compare
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Jan 13, 2026
Collaborator
|
Commit: 03b5ab1
34 interesting tests: 15 RECOVERED, 10 KNOWN, 8 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 103130c
35 interesting tests: 19 RECOVERED, 9 flaky, 6 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modifies
databricks bundle generate appto skipnode_modulesdirectories when downloading app source code.Changes
node_moduleswithout listing its contentsImplementation
The implementation uses
path.Base()to check if a directory name is "node_modules" before recursing:Since we check directories as we encounter them (not after recursing), we only need this simple one-line check.
Benefits
Testing
🤖 Generated with Claude Code