-
Notifications
You must be signed in to change notification settings - Fork 127
Add since_version to bundle schema #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shreyas-goenka
wants to merge
7
commits into
main
Choose a base branch
from
version-annotations-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,727
−1,023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Commit: 7435802
73 interesting tests: 43 FAIL, 19 RECOVERED, 6 KNOWN, 4 flaky, 1 SKIP
Top 37 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
x-since-versionfield to the bundle JSON schema output, indicating which CLI version each field was introduced in. This version information will be displayed in our documentation.The implementation:
annotations.ymlandannotations_openapi_overrides.yml).last_processed_cli_versionto process versions incrementallyx-since-versionin the generated JSON schemaTest plan
make schemagenerates schema with version annotationsmake lintpassesNote: There's a off by one problem here where the version information will only be updated in the next release. That is if a feature is released in v1, the metadata will only show up in the JSON schema in v2. This is because the code relies on already done releases.