-
Notifications
You must be signed in to change notification settings - Fork 482
Change default value for delta_sharing_recipient_token_lifetime_in_seconds from 0 to 31536000 (1 year)
#5296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…` from 0 to 31536000 (1 year)
8bf36b0 to
5f84305
Compare
5f84305 to
595d1da
Compare
alexott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments:
- Should we set the default value in the schema customization function?
- If we submitted non-zero value, then we should get that non-zero value back when reading the data. This may lead to configuration drift...
alexott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, small change in the docs is necessary
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
We now restrict
delta_sharing_recipient_token_lifetime_in_secondslifetime of a token to be 1 year.Source: https://docs.databricks.com/aws/en/release-notes/whats-coming#changes-to-open-delta-sharing-recipient-tokens
The default currently is 0, which is no longer possible. This PR sets the default to 31536000 (1 year) and removes the unlimited lifetime reference in the docs.
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile