Update custom server instructions to support deploying both via apps & bundles CLI#36
Merged
smurching merged 5 commits intodatabrickslabs:masterfrom Jun 8, 2025
Conversation
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
smurching
commented
Jun 8, 2025
| apps: | ||
| custom-mcp-server: | ||
| name: "custom-mcp-server" | ||
| name: "mcp-custom-server-bundles" |
Contributor
Author
There was a problem hiding this comment.
To avoid conflict with the one deployed via apps CLI
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
smurching
commented
Jun 8, 2025
|
|
||
| # note the order of mounting here, | ||
| # and don't change it unless you know what you're doing | ||
| app.mount("/api", mcp_app) |
Contributor
Author
There was a problem hiding this comment.
We have some upcoming product features that expect that the MCP server is hosted at /mcp instead of /api/mcp (and /mcp is also the default when using FastMCP), so updating to reflect that
smurching
commented
Jun 8, 2025
| <pre class="bg-gray-900 p-3 rounded overflow-x-auto"> | ||
| <code class="language-python"> | ||
| from databricks.sdk import WorkspaceClient | ||
| from databricks_mcp import DatabricksOAuthClientProvider |
Contributor
Author
There was a problem hiding this comment.
Using this new API to configure auth. We'll also recommend this in docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
See title
How is this PR tested?
Manually ran through both the apps CLI and bundles deployment flows
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
How should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes