Skip to content

Absolute path fix #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjtantaylatimes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Absolute path fix #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.47.8]
### Changed
- Removed ternary operator and URL object instantiation from `absoluteUrl` generation in Nunjucks engine, simplifying it to use `currentPath` directly

## [0.47.7] - 2024-02-13

### Added
Expand Down
7 changes: 1 addition & 6 deletions lib/engines/nunjucks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,8 @@ export class NunjucksEngine extends BaseEngine {
...parts,
});

// build the complete URL, using this.domain if it's set
const currentUrl = this.domain
? new URL(currentPath, this.domain)
: currentPath;

// prepare the absolute URL to be passed to context
const absoluteUrl = currentUrl.toString();
const absoluteUrl = currentPath;

// prep the page tracking object
// TODO: get rid of the snakecase variables in 1.0
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@datagraphics/baker",
"type": "module",
"version": "0.47.7",
"version": "0.47.8",
"exports": "./lib/index.js",
"files": [
"bin",
Expand Down