This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Make :above and :below move items directly above and belove the given item.#4
Open
rdvdijk wants to merge 1 commit intodatamapper:masterfrom
Open
Make :above and :below move items directly above and belove the given item.#4rdvdijk wants to merge 1 commit intodatamapper:masterfrom
rdvdijk wants to merge 1 commit intodatamapper:masterfrom
Conversation
Author
|
Does anyone ever look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that when using :below and :above does not move items if the given item is already below or above the target item. So:
Moving '2' above '4' would do nothing, since '2' is already above '4'. However, I feel that moving '2' above '4' should place it directly above it, and resulting in:
Same holds for :below. I've created tests for these cases and altered the code.
Kind regards,
Roel