Open
Conversation
Fixes #13. Google sheet is now cached and update-sheet can be run to refresh it Also fixes error handling for updateUserFromSheet
Member
|
@christopherm99 does everything work according to plan when you test it? If so I'm down to approve and merge |
Contributor
Author
Works on my test server. |
Member
|
Also @christopherm99 do you have a test sheet, if so you can message it to me and I can test it on my test server just for some more testing before we merge |
colinpcurtis
requested changes
Jan 23, 2023
|
|
||
| users.forEach(async (doc) => { | ||
| if (doc && ids_in_guild.includes(doc.user_id)) { | ||
| updateUserFromSheet(doc.email, doc.user_id, interaction.client); |
Member
There was a problem hiding this comment.
we should wrap this in try/catch or at least handle the status that's returned from updateUserFromSheet to return an error to the user.
Currently, if we get some issue in that function it will not return anything to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Google sheet is now cached and update-sheet can be run to refresh it.
Also fixes error handling for updateUserFromSheet.
TODO: Make
/update-alland/update-sheetonly runnable by admins.