fix: Pyarrow codebase dependencies not removed#123
Open
frayle-ons wants to merge 3 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Pull Request Template
✨ Summary
As part #117 we removed several non-immediate dependencies from the package including PyArrow, PyArrow also corresponded to several stakeholder requests that this library was causing dependency issues with users' existing codebases.
However, several of our Polar's datamframe operations still rely on the use of the PyArrow back end leading to
ModuleNotFoundErrorerrors in both the VectorStoresearch()andreverse_search()methods.These have been resolved by using alternate Polars methods that do not require PyArrow under the hood.
Additionally, I've updated the package version number in the uv lock file and also set name mappings in for deptry for google-genai and ollama optional installations.
The code changes now allow us to run all the DEMO folder Jupyter notebooks without error, which seems like a good test.
📜 Changes Introduced
✅ Checklist
terraform fmt&terraform validate)🔍 How to Test
Running each of the notebooks after building the branch from source showed no more issues. The changes introduced to the pyproject.toml also smoothed out issues seem before with pre-commit deputy