Conversation
This was referenced Feb 17, 2020
gka
added a commit
that referenced
this pull request
Jun 26, 2022
* test: add e2e test that tests email login + logout * chore: add demo test for simple-maps * chore: use page object pattern * chore: click "visualize" at end of test * chore(frontend): make wdio/cli a dev dependency * chore: remove chromedriver for now * chore: fix signin test * chore: make sure eslint env applies to all pageobjects * fix login test * e2e: Bring improvements from cypress tests - Move to utils/e2e-tests. - Enable and fix simple-maps test. - Log in using the API. - Remove PageObjects, which we don't need yet. - Use service-utils/findConfig. - Add test runner command getDwConfig. - Add README. - Add GitHub Actions workflow. * controls/v3: Lint * e2e: Allow choosing browser And remove boilerplate from wdio.conf.js. * wdio.conf: Remove more boilerplane * e2e: Use Chrome by default * e2e: Fix data-upload in Chrome * wdio: Send custom HTTP headers And improve waitForUrl message. * wdio: Use modheader to set headers * e2e: Add dev and staging configs * e2e: Fix tests on staging * e2e/smoke: Add chart creation test * code/package.json: Clean * e2e: Teardown, fix data-upload, split commands * e2e/smoke: Fix on staging * e2e/README: Minor fixes * e2e/wdio: Improve comments * e2e/README: Describe where to get CF_ACCESS values * e2e/config.staging: Make the config valid * e2e/signin: Update URLs to support local w/ oauth * e2e/signin: Make the test cases independent * Increase browser timeout for signin to account for slow environments Co-authored-by: Jakub Valenta <jakub@datawrapper.de> Co-authored-by: Simon Jockers <449739+sjockers@users.noreply.github.com>
gka
added a commit
that referenced
this pull request
Sep 3, 2023
* test: add e2e test that tests email login + logout * chore: add demo test for simple-maps * chore: use page object pattern * chore: click "visualize" at end of test * chore(frontend): make wdio/cli a dev dependency * chore: remove chromedriver for now * chore: fix signin test * chore: make sure eslint env applies to all pageobjects * fix login test * e2e: Bring improvements from cypress tests - Move to utils/e2e-tests. - Enable and fix simple-maps test. - Log in using the API. - Remove PageObjects, which we don't need yet. - Use service-utils/findConfig. - Add test runner command getDwConfig. - Add README. - Add GitHub Actions workflow. * controls/v3: Lint * e2e: Allow choosing browser And remove boilerplate from wdio.conf.js. * wdio.conf: Remove more boilerplane * e2e: Use Chrome by default * e2e: Fix data-upload in Chrome * wdio: Send custom HTTP headers And improve waitForUrl message. * wdio: Use modheader to set headers * e2e: Add dev and staging configs * e2e: Fix tests on staging * e2e/smoke: Add chart creation test * code/package.json: Clean * e2e: Teardown, fix data-upload, split commands * e2e/smoke: Fix on staging * e2e/README: Minor fixes * e2e/wdio: Improve comments * e2e/README: Describe where to get CF_ACCESS values * e2e/config.staging: Make the config valid * e2e/signin: Update URLs to support local w/ oauth * e2e/signin: Make the test cases independent * Increase browser timeout for signin to account for slow environments Co-authored-by: Jakub Valenta <jakub@datawrapper.de> Co-authored-by: Simon Jockers <449739+sjockers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure users can't sign up twice with identical email addresses we ultimately need to add a UNIQUE constraint to this field in MySQL. This PR is still a work in progress...
Related PRs: