Skip to content

Ensure non-ASCII characters in menus show properly #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davep merged 1 commit into from
Dec 12, 2025
Merged

Ensure non-ASCII characters in menus show properly #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# AgiNG ChangeLog

## Unreleased

**Released: WiP**

- Fixed a cosmetic glitch in the menus of some guides with non-ASCII
characters in the prompts.

## v1.1.0

**Released: 2025-01-02**
Expand Down
8 changes: 5 additions & 3 deletions src/aging/widgets/guide_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

##############################################################################
# NGDB imports.
from ngdb import Entry, Link, Menu, NortonGuide
from ngdb import Entry, Link, Menu, NortonGuide, make_dos_like

##############################################################################
# Textual imports.
Expand Down Expand Up @@ -32,7 +32,7 @@ def __init__(self, menu_id: int, menu: Menu) -> None:
"""
self._menu = menu
"""The menu we're displaying."""
super().__init__(f"[bold]{menu.title}[/]", id=str(menu_id))
super().__init__(f"[bold]{make_dos_like(menu.title)}[/]", id=str(menu_id))

@property
def first_child_id(self) -> str:
Expand All @@ -54,7 +54,9 @@ def __init__(self, menu_id: int, prompt_id: int, menu_prompt: Link) -> None:
"""
self._menu_prompt = menu_prompt
"""The prompt that this object is displaying."""
super().__init__(f" {menu_prompt.text}", id=f"{menu_id}-{prompt_id}")
super().__init__(
f" {make_dos_like(menu_prompt.text)}", id=f"{menu_id}-{prompt_id}"
)

@property
def offset(self) -> int:
Expand Down