WIP: Add solved/reconstructed fluxmap support.#553
Open
tdaede wants to merge 1 commit intodavidgiven:masterfrom
Open
WIP: Add solved/reconstructed fluxmap support.#553tdaede wants to merge 1 commit intodavidgiven:masterfrom
tdaede wants to merge 1 commit intodavidgiven:masterfrom
Conversation
Contributor
Author
|
Moved solved encoder creation into arch/. |
This proof of concept adds an optional encoder and fluxsink that runs after the image is written. This currently exposes the config of the solvedEncoder, though I think I ultimately don't want it to be exposed as part of the config proto. Another way to do this would be by extending the decoders and/or directly reading their records. That is actually closer to what I want in many ways, however those records would need to be deduplicated from multiple reads, etc. The ultimate goal is to exactly replicate the timing of the original sectors, but with a stable clock, sectors reread if a bad read happens, and garbage between sectors removed. This requires extending the sector struct to have more information than it currently holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proof of concept adds an optional encoder and fluxsink that
runs after the image is written.
This currently exposes the config of the solvedEncoder, though I
think I ultimately don't want it to be exposed as part of the
config proto.
Another way to do this would be by extending the decoders and/or
directly reading their records. That is actually closer to what I
want in many ways, however those records would need to be
deduplicated from multiple reads, etc.
The ultimate goal is to exactly replicate the timing of the
original sectors, but with a stable clock, sectors reread if a
bad read happens, and garbage between sectors removed. This
requires extending the sector struct to have more information
than it currently holds.