feat: partial update APIs by davidkelley · Pull Request #101 · davidkelley/searchlite

davidkelley · 2026-02-04T12:58:20Z

Summary

add core partial update patching with validation + tests
add HTTP update and bulk update endpoints (best-effort) + tests
document update APIs in OpenAPI and README

Test Plan

cargo test --all --all-features
cargo clippy --all --all-features --all-targets -- -D warnings
cargo build --all --all-features
cargo llvm-cov --all --all-features --json --summary-only --output-path /tmp/llvm-cov-summary.json
cargo bench -p searchlite-core

Coverage

Lines: 82.85% (workspace)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e42e937126

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

Copilot

Pull request overview

Adds partial document update support (set/unset patches) across core and HTTP APIs, with bulk NDJSON update support and accompanying docs/tests.

Changes:

Introduces IndexWriter::apply_patch with patch validation and JSON path set/unset helpers.
Adds HTTP endpoints for single update (/indexes/:name/update) and best-effort bulk update (/indexes/:name/_bulk_update) plus integration tests.
Updates OpenAPI/README and adds design + implementation plan docs for partial updates.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
searchlite-http/src/lib.rs	Adds update + bulk update routes, request/response structs, handlers, and HTTP tests; minor multi_search handling tidy-up.
searchlite-core/src/api/writer.rs	Implements `apply_patch` and helper functions to load/patch/validate documents.
searchlite-core/tests/partial_update.rs	Adds core tests covering set/unset, nested paths, and validation failures.
openapi.yaml	Documents new update and bulk update endpoints and schemas.
README.md	Documents new endpoints in the API overview and adds curl examples.
docs/plans/2026-02-04-issue-89-partial-update-implementation.md	Adds implementation plan for issue #89 partial update.
docs/plans/2026-02-04-issue-89-partial-update-design.md	Adds design notes/constraints for partial update behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/plans/2026-02-04-issue-89-partial-update-implementation.md

searchlite-core/src/api/writer.rs

searchlite-http/src/lib.rs

- consult pending ops before loading patch source - rename update response field to accepted - update API docs and remove docs/plans 🤖 Generated with Codex

davidkelley · 2026-02-04T13:31:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 487baa6d9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

searchlite-http/src/lib.rs

- add patch error type and vector update guard - stream bulk updates and avoid string matching - document vector update restriction 🤖 Generated with Codex

davidkelley · 2026-02-05T09:41:35Z

@codex review

chatgpt-codex-connector · 2026-02-05T09:47:37Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

searchlite-http/src/lib.rs

searchlite-core/src/api/writer.rs

davidkelley · 2026-02-05T14:03:17Z

@codex review

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97616a09a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

- accept nested field root paths during patch validation - add regression tests for nested root acceptance/rejection - add end-to-end apply_patch test for replacing nested roots

davidkelley

Addressed pending review updates.

searchlite-http/src/lib.rs

searchlite-core/src/api/writer.rs

davidkelley · 2026-02-10T09:55:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16f6c98e42

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

- traverse arrays while applying set/unset dotted paths - add regression tests for set_path/unset_path array traversal - add apply_patch test covering nested-array dotted updates

davidkelley · 2026-02-10T12:54:18Z

@codex review

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c5ad22f25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-http/src/lib.rs

- expose writer checkpoint/rollback_to for request-scoped rollback - bulk update abort now rolls back only request changes - add regression test for preserving pre-existing queued writes

davidkelley · 2026-02-10T13:23:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c404884c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

- cache pending latest state by doc id for O(1) lookups - reuse an IndexReader while applying patches - add regression test for fresh committed state across commits

davidkelley · 2026-02-10T14:03:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cf547768c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

- refresh apply_patch reader cache when manifest stamp changes\n- keep reader reuse for stable manifest generations\n- add regression test for interleaved external commit

davidkelley · 2026-02-10T14:24:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ca7a9db15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

searchlite-core/src/api/writer.rs

- only allow ancestor patch paths for declared nested fields\n- apply patches to literal dotted top-level field names as single keys\n- add regression tests for dotted field validation and update behavior

davidkelley · 2026-02-10T15:04:52Z

@codex review

chatgpt-codex-connector · 2026-02-10T15:20:36Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

davidkelley added 9 commits February 4, 2026 11:54

docs: add issue 89 partial update design

cc58501

docs: add issue 89 partial update implementation plan

1558eed

feat(core): add partial update writer support

427cd3a

feat(core): validate partial update patches

dd3f5ee

feat(http): add update document endpoint

d74360a

feat(http): add bulk update endpoint

baa96aa

docs: document partial update APIs

0778273

test: add vector_fields to partial update schemas

c653d2a

chore: tidy multi_search request handling

e42e937

Copilot AI review requested due to automatic review settings February 4, 2026 12:58

Copilot started reviewing on behalf of davidkelley February 4, 2026 12:58 View session

davidkelley changed the title ~~plan/issue 89 partial update~~ feat: partial update APIs Feb 4, 2026

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Outdated Show resolved Hide resolved

Copilot AI reviewed Feb 4, 2026

View reviewed changes

docs/plans/2026-02-04-issue-89-partial-update-implementation.md Outdated Show resolved Hide resolved

searchlite-core/src/api/writer.rs Show resolved Hide resolved

searchlite-http/src/lib.rs Outdated Show resolved Hide resolved

fix: address PR review feedback

487baa6

- consult pending ops before loading patch source - rename update response field to accepted - update API docs and remove docs/plans 🤖 Generated with Codex

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Show resolved Hide resolved

chore: ignore docs plans

40ceb76

davidkelley requested a review from Copilot February 4, 2026 17:06

Copilot started reviewing on behalf of davidkelley February 4, 2026 17:07 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

searchlite-http/src/lib.rs Outdated Show resolved Hide resolved

searchlite-http/src/lib.rs Show resolved Hide resolved

searchlite-http/src/lib.rs Outdated Show resolved Hide resolved

fix: address remaining review feedback

8b37053

- add patch error type and vector update guard - stream bulk updates and avoid string matching - document vector update restriction 🤖 Generated with Codex

davidkelley requested a review from Copilot February 5, 2026 13:11

Copilot started reviewing on behalf of davidkelley February 5, 2026 13:11 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

searchlite-http/src/lib.rs Outdated Show resolved Hide resolved

searchlite-http/src/lib.rs Show resolved Hide resolved

searchlite-core/src/api/writer.rs Show resolved Hide resolved

fix: harden update validation and reduce multi_search cloning

97616a0

davidkelley requested a review from Copilot February 5, 2026 14:03

Copilot started reviewing on behalf of davidkelley February 5, 2026 14:03 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 5, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Show resolved Hide resolved

fix: allow patching nested field roots

16f6c98

- accept nested field root paths during patch validation - add regression tests for nested root acceptance/rejection - add end-to-end apply_patch test for replacing nested roots

davidkelley commented Feb 10, 2026

View reviewed changes

searchlite-http/src/lib.rs Outdated Show resolved Hide resolved

searchlite-http/src/lib.rs Show resolved Hide resolved

searchlite-core/src/api/writer.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Outdated Show resolved Hide resolved

davidkelley requested a review from Copilot February 10, 2026 12:11

Copilot started reviewing on behalf of davidkelley February 10, 2026 12:11 View session

fix: support dotted patch paths through nested arrays

0c5ad22

- traverse arrays while applying set/unset dotted paths - add regression tests for set_path/unset_path array traversal - add apply_patch test covering nested-array dotted updates

Copilot AI reviewed Feb 10, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

searchlite-http/src/lib.rs Outdated Show resolved Hide resolved

fix: preserve pending writes on bulk update abort

1c40488

- expose writer checkpoint/rollback_to for request-scoped rollback - bulk update abort now rolls back only request changes - add regression test for preserving pre-existing queued writes

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Outdated Show resolved Hide resolved

searchlite-core/src/api/writer.rs Outdated Show resolved Hide resolved

perf: optimize patch source resolution

5cf5477

- cache pending latest state by doc id for O(1) lookups - reuse an IndexReader while applying patches - add regression test for fresh committed state across commits

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Outdated Show resolved Hide resolved

fix: refresh cached patch reader on manifest changes

0ca7a9d

- refresh apply_patch reader cache when manifest stamp changes\n- keep reader reuse for stable manifest generations\n- add regression test for interleaved external commit

chatgpt-codex-connector bot reviewed Feb 10, 2026

View reviewed changes

searchlite-core/src/api/writer.rs Show resolved Hide resolved

fix: treat dotted patch paths as literal top-level keys

760f5b5

- only allow ancestor patch paths for declared nested fields\n- apply patches to literal dotted top-level field names as single keys\n- add regression tests for dotted field validation and update behavior

davidkelley merged commit 2b6f5de into main Feb 10, 2026
6 checks passed

davidkelley deleted the plan/issue-89-partial-update branch February 10, 2026 15:56

davidkelley linked an issue Feb 10, 2026 that may be closed by this pull request

#3: Partial update/unset API #89

Closed

This was referenced Feb 10, 2026

chore: release #99

Open

feat/nested aggregations #102

Open

Conversation

davidkelley commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Coverage

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidkelley commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidkelley commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidkelley commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

davidkelley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidkelley commented Feb 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

davidkelley commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

davidkelley commented Feb 10, 2026

davidkelley commented Feb 4, 2026 •

edited

Loading