Refactor case sensitivity handling for system names #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update App.tsx to normalize system names before comparison - Update runner.py to normalize system names in make_uploader - Update system_commands.py to handle both formats (e.g., "Roam Research" and "roam") - Update blob_uploader.py to normalize BLOB_STORAGE_SYSTEM value This resolves inconsistencies between UI representation and backend handling of system names like "Roam Research" vs "roam" and "Dropbox" vs "dropbox". 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add centralized mapping system and normalization functions in settings.py
- Implement NOTE_TAKING_SYSTEM_MAP and DISPLAY_NAME_MAP dictionaries
- Add normalize_system_name() and get_display_name() utility functions
- Replace direct lowercase conversions with normalized lookups
- Update frontend and backend to use the normalized system names
This provides a more elegant, maintainable solution to handle case sensitivity issues between UI display names ("Roam Research") and internal identifiers ("roam").
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
normalize_system_name()andget_display_name()to standardize system name handlingOriginal task
the key for Roam Research for the NOTE_TAKING_SYSTEM is roam, not 'Roam Research' -- current the settings server is setting Roam Research instead / looking for that and not showing the right thing when it finds 'roam' instead; pls fix. same for Dropbox vs dropbox etc.
This PR offers a more elegant and maintainable solution than the approach in PR #97 by centralizing the mapping logic in the settings module instead of having scattered lowercase conversions and multiple switch statements with similar conditions.
🤖 Generated with Claude Code