adding support for the five day forecast API #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgm702
force-pushed
the
add-support-for-five-day-forecast
branch
2 times, most recently
from
dd9a95e to
bdb7485
Compare
mgm702
force-pushed
the
add-support-for-five-day-forecast
branch
from
bdb7485 to
fff1abc
Compare
dblock
reviewed
Mar 20, 2025
dblock
requested changes
Mar 20, 2025
Owner
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
Looking great! Thank you. See comments above/fix CI.
Owner
|
Merged, thanks! I'll make a release. |
Owner
|
Since you're here, any interest in also picking up #5? |
Contributor
Author
|
yeah I can take care of that one too. Give me a few days and Ill push up a PR |
Owner
Don't hesitate to take others :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this API for a project and saw this endpoint was missing from your gem. Saw the add five day support issue and decided to help out.