Skip to content

zkutils: auto remove the ZK docker container #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jieyu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

zkutils: auto remove the ZK docker container #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion testutils/zk_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ func StartZookeeper(opts ...func(*ZKConfig)) (*ZkControl, error) {

// the container IP is not routable on Darwin, thus needs port
// mapping for the container.
hostConfig := &container.HostConfig{}
hostConfig := &container.HostConfig{
AutoRemove: true,
Copy link
Contributor

@jdef jdef Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of hard-coding this, maybe make it a field in ZKConfig and then you can configure it using a functional option. I'd like to avoid hard-coding new things here.

}
if runtime.GOOS == "darwin" {
hostConfig.PortBindings = nat.PortMap{
nat.Port(fmt.Sprintf("%d/tcp", config.ClientPort)): []nat.PortBinding{{
Expand Down