Feature/elo exports and imports #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependency - Updated voting.server.ts to streamline session fetching and remove unnecessary service session filtering. - Modified _layout.agenda.$year.talk.$sessionId.tsx to simplify session retrieval logic and eliminate timezone dependency. - Adjusted _layout.agenda.($year).tsx to remove timezone handling from session fetching. - Enhanced admin.voting-validation.stats.$runId.tsx to include sessionize data in voting results and improve error handling. - Updated admin.voting.tsx to manage underrepresented groups configuration and improve error reporting. - Refactored app-agenda-grid.tsx, app-agenda-sessions.tsx, and app-agenda-speakers.tsx to remove conferenceConfigPublic dependency and simplify session fetching logic.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements ELO exports and imports functionality for the voting validation system, along with underrepresented groups configuration. The changes enable exporting voting data to external ELO ranking tools and importing the calculated results back into the system for improved talk ranking and diversity tracking.
- Adds underrepresented groups configuration management in the admin interface
- Implements ELO ranking export/import functionality with vote data export and results upload
- Refactors session data handling to work with individual sessions instead of grouped sessions
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| website/app/routes/app-agenda-speakers.tsx | Removes timezone parameter from speaker data fetching |
| website/app/routes/app-agenda-sessions.tsx | Refactors session processing to handle individual sessions and removes timezone dependency |
| website/app/routes/app-agenda-grid.tsx | Removes timezone parameter from schedule grid fetching |
| website/app/routes/admin.voting.tsx | Adds underrepresented groups configuration UI and management functionality |
| website/app/routes/admin.voting-validation.stats.$runId.tsx | Implements ELO results import/export and displays ranked results with underrepresented group indicators |
| website/app/routes/admin.voting-validation.stats.$runId.download.tsx | New route for exporting vote data as JSON for external ELO tools |
| website/app/routes/_layout.agenda.($year).tsx | Removes timezone parameter from agenda data fetching |
| website/app/routes/_layout.agenda.$year.talk.$sessionId.tsx | Refactors to work with individual sessions instead of grouped sessions |
| website/app/lib/voting.server.ts | Updates session data processing to handle individual sessions |
| website/app/lib/voting-validation.server.ts | Adds vote result storage, ELO result management, and underrepresented groups configuration |
| website/app/lib/voting-validation-types.ts | Defines new types for ELO results, vote results, and underrepresented groups configuration |
| website/app/lib/sessionize.server.ts | Refactors to return individual sessions and adds underrepresented groups data extraction |
| website/app/lib/session-info.server.ts | Adds underrepresented groups question ID configuration |
| website/app/config/years/*.server.ts | Adds underrepresented groups question ID configuration for each conference year |
|
|
||
| export async function getUnderrepresentedGroupsConfig(votesTableClient: TableClient): Promise<string[]> { | ||
| try { | ||
| const partitionKey: UnderrepresentedGroupsConfig['partitionKey'] = 'ddd' |
There was a problem hiding this comment.
The hardcoded partition key 'ddd' should be replaced with a meaningful constant or configuration value to improve code maintainability and clarity.
Suggested change
| const partitionKey: UnderrepresentedGroupsConfig['partitionKey'] = 'ddd' | |
| const partitionKey: UnderrepresentedGroupsConfig['partitionKey'] = UNDERREPRESENTED_GROUPS_PARTITION_KEY |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.