Skip to content

remove unecessary log#1541

Merged
guitavano merged 1 commit intomainfrom
tavano/remove-log
Mar 2, 2026
Merged

remove unecessary log#1541
guitavano merged 1 commit intomainfrom
tavano/remove-log

Conversation

@guitavano
Copy link
Contributor

@guitavano guitavano commented Mar 2, 2026

What is this Contribution About?

Please provide a brief description of the changes or enhancements you are proposing in this pull request.

Issue Link

Please link to the relevant issue that this pull request addresses:

Loom Video

Record a quick screencast describing your changes to help the team understand and review your contribution. This will greatly assist in the review process.

Demonstration Link

Provide a link to a branch or environment where this pull request can be tested and seen in action.


Summary by cubic

Removed the canShowWarning helper and the warning log in getOptimizedMediaUrl to reduce noisy server logs when image optimization is disabled. No behavior change; only logging cleanup.

Written for commit bd6b5b5. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Removed runtime warning messages from the image optimization system. Warning notifications that appeared during disabled image optimization have been eliminated. No changes to image optimization functionality or behavior.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ac959b and bd6b5b5.

📒 Files selected for processing (1)
  • website/components/Image.tsx

📝 Walkthrough

Walkthrough

The PR removes a runtime warning mechanism from the Image component, specifically deleting the canShowWarning helper function and eliminating a conditional warning block in getOptimizedMediaUrl that reported when automatic image optimization was disabled for non-Supabase sources.

Changes

Cohort / File(s) Summary
Warning logic removal
website/components/Image.tsx
Deleted canShowWarning function and removed conditional warning block in getOptimizedMediaUrl. All other optimization paths remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • deco-cx/apps#1501 — Also modifies getOptimizedMediaUrl in the same file, adjusting behavior for non-Supabase image sources
  • deco-cx/apps#1404 — Previously introduced the canShowWarning gate to control console warnings in browser/deploy environments
  • deco-cx/apps#1452 — Related modifications to getOptimizedMediaUrl URL construction and host handling logic

Suggested reviewers

  • aka-sacci-ccr
  • vibe-dex
  • mcandeia

Poem

🐰 A warning, once loud, now fades away,
Cleaning the noise of yesterday,
Simpler code hops forth with glee—
Less chatter, more harmony! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tavano/remove-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@guitavano guitavano merged commit c7dd58e into main Mar 2, 2026
4 of 5 checks passed
@guitavano guitavano deleted the tavano/remove-log branch March 2, 2026 16:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.137.2 update
  • 🎉 for Minor 0.138.0 update
  • 🚀 for Major 1.0.0 update

guitavano added a commit that referenced this pull request Mar 2, 2026
guitavano added a commit that referenced this pull request Mar 2, 2026
guitavano added a commit that referenced this pull request Mar 2, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

guitavano added a commit that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant