multi: add fee and feerate fields to TrimmedTx and Tx API types #2029
Open
ukane-philemon wants to merge 2 commits intodecred:masterfrom
Open
multi: add fee and feerate fields to TrimmedTx and Tx API types #2029ukane-philemon wants to merge 2 commits intodecred:masterfrom
ukane-philemon wants to merge 2 commits intodecred:masterfrom
Conversation
This PR adds fee and feerate fields (in atoms) to apitypes.TrimmedTx and apitypes.Tx. These fields
are now available across the api endpoints listed below:
```txt
- GET /tx/{txid}
- GET /tx/{txid}/trimmed
- GET /tx/decoded/{txid}
- POST /txs
- POST /txs/trimmed
```
The new fields provide precise transaction fee information in atoms for both mempool
and mined transactions.
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
dajohi
requested changes
Nov 6, 2025
Member
dajohi
left a comment
dajohi
left a comment
There was a problem hiding this comment.
needs /mempool transactions columns to match /block transactions columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fee and feerate fields (in atoms) to apitypes.TrimmedTx and apitypes.Tx. These fields
are now available across the api endpoints listed below:
- GET /tx/{txid} - GET /tx/{txid}/trimmed - GET /tx/decoded/{txid} - POST /txs - POST /txs/trimmedThe new fields provide precise transaction fee information in atoms for both mempool
and mined transactions.
Closes #470