Merged
Conversation
jholdstock
requested changes
Mar 17, 2022
Member
jholdstock
left a comment
jholdstock
left a comment
There was a problem hiding this comment.
I've left a few comments here. I think that addressing these comments will result in some significant changes to the PR, so to avoid wasting time I won't review in more detail until they are sorted.
Contributor
Author
|
@jholdstock thanks for the review, changes have been applied. |
ukane-philemon
force-pushed
the
helperfuncs
branch
from
c0e65d1 to
d5b3062
Compare
ukane-philemon
force-pushed
the
helperfuncs
branch
from
d5b3062 to
746e7d9
Compare
Member
|
Going to merge this with a couple of minor outstanding issues. I will fix those myself in a follow-up PR shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diiff adds new helper funcs
validateTicketHash()andgetCommitmentAddress(). Also it modifies helper funcvalidateSignature(). Originally part of #322