Skip to content

Separate regression tests into parallel CI job with continue-on-error #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepentropy merged 2 commits into from
Dec 5, 2025
Merged

Separate regression tests into parallel CI job with continue-on-error #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99841bd
Initial plan
Copilot Dec 5, 2025
ce33827
Separate regression tests into their own CI job
Copilot Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ on:
required: false
default: false
type: boolean
run_pinesuite_tests:
description: 'Run PineSuite regression tests'
required: false
default: true
type: boolean

jobs:
build-and-test:
Expand All @@ -38,23 +33,37 @@ jobs:

- name: Build all packages
run: pnpm build

- name: Debug - Check PINESUITE_TOKEN
if: ${{ github.event. inputs.debug_enabled == 'true' }}
run: |
if [ -n "$PINESUITE_TOKEN" ]; then
echo "✅ PINESUITE_TOKEN is set (length: ${#PINESUITE_TOKEN})"
echo "First 4 chars: ${PINESUITE_TOKEN:0:4}..."
else
echo "❌ PINESUITE_TOKEN is NOT set"
fi
env:
PINESUITE_TOKEN: ${{ secrets. PINESUITE_TOKEN }}

- name: Run tests
- name: Run unit tests (excluding regression)
run: pnpm test
env:
PINESUITE_TOKEN: ${{ secrets. PINESUITE_TOKEN }}
PINESUITE_TOKEN: ${{ secrets.PINESUITE_TOKEN }}

- name: Type check
run: pnpm typecheck

regression-tests:
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v2
with:
version: 8

- uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'pnpm'

- name: Install dependencies
run: pnpm install

- name: Build all packages
run: pnpm build

- name: Run regression tests
run: pnpm test:regression
env:
PINESUITE_TOKEN: ${{ secrets.PINESUITE_TOKEN }}
3 changes: 2 additions & 1 deletion packages/pine2ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
],
"scripts": {
"build": "tsup src/index.ts --format cjs,esm --dts",
"test": "vitest run",
"test": "vitest run --exclude='**/regression/**'",
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single quotes in the --exclude argument may cause issues. In JSON strings, these quotes become part of the command and could be interpreted literally by the shell. Consider using double quotes with escaping instead: "test": "vitest run --exclude \"**/regression/**\"" or removing quotes entirely: "test": "vitest run --exclude **/regression/**"

Suggested change
"test": "vitest run --exclude='**/regression/**'",
"test": "vitest run --exclude=**/regression/**",

Copilot uses AI. Check for mistakes.
"test:all": "vitest run",
"test:watch": "vitest",
"test:pinesuite": "vitest run tests/regression/pinesuite-regression.test.ts",
"typecheck": "tsc --noEmit",
Expand Down
Loading