Skip to content

fix: close dns tracing default #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
taloric wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: close dns tracing default #376

taloric wants to merge 1 commit into from
+11 −9

Conversation

@taloric
Copy link
Contributor

@taloric taloric commented Dec 26, 2025 •
edited
Loading

  • 把 dns 追踪默认关掉
  • 实际上大部分情况下都不需要 dns 追踪，且 dns 追踪由于终点一般都在 coredns，容易产生 sys span 误关联，导致查询巨慢；目前看来收益 <<<< 成本，所以先默认关掉

@taloric taloric requested a review from sharang December 26, 2025 02:15
@taloric taloric force-pushed the support_trace_id_range branch 5 times, most recently from 6160add to da90b39 Compare December 31, 2025 11:27
@taloric taloric marked this pull request as ready for review December 31, 2025 11:27
@taloric taloric changed the title fix: support trace_id range searching fix: close dns tracing default Dec 31, 2025
@taloric taloric force-pushed the support_trace_id_range branch from da90b39 to c4e4c0e Compare January 5, 2026 06:22
@taloric
Copy link
Contributor Author

taloric commented Jan 5, 2026 •
edited
Loading

如图：
这些 dns 请求，无论是在客户端侧，还是在服务端侧，通过同一线程的互相追踪，带出了多个逻辑上没什么关系的关联请求，误关联率太大了，而且查询耗时较久，没什么正收益
img_v3_02tl_5266bc11-cf35-4ab3-a910-2f7e1bacd28g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharang sharang Awaiting requested review from sharang

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@taloric