optimize lua cpu cost #11118
Open
optimize lua cpu cost #11118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@qlndzt 验证结果贴个图 |
Collaborator
Author
修改后profiler大概占用～1%cpu，修改前（python/lua都未处理）～100%
|
| return 1; | ||
| } | ||
|
|
||
| detect_runtime_cached(pid as u32).is_some() as i32 |
Contributor
There was a problem hiding this comment.
我看这里多加了一层cache，和直接用detect_runtime_uncached相比，性能上是能多优化很多吗？
Collaborator
Author
There was a problem hiding this comment.
应该是的，之前有stringifier lua的判断放在了最前面，这里主要是避免对非 Lua 进程反复扫maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for:
Improves the performance of is_lua_process
Added benchmark
Benchmark result