Feat: hybrid CPU/GPU n-gram hashing with automatic path selection#15
Open
Playmaker3334 wants to merge 10 commits intodeepseek-ai:mainfrom
Open
Feat: hybrid CPU/GPU n-gram hashing with automatic path selection#15Playmaker3334 wants to merge 10 commits intodeepseek-ai:mainfrom
Playmaker3334 wants to merge 10 commits intodeepseek-ai:mainfrom
Conversation
- Convert CUDA tensors to CPU before numpy conversion in CompressedTokenizer - Fixes TypeError when running on GPU: 'can't convert cuda:0 device type tensor to numpy' - Maintains backward compatibility with CPU-only usage
- Use actual tokenizer vocab size instead of config value - Prevents IndexError when generating test data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds GPU support to the Engram demo and fixes bugs that prevented it from running on CUDA devices.
Bug Fixes
torch.from_numpy()inEngram.forward()always created CPU tensors, causing runtime errors when model was on GPUCompressedTokenizer._compress()had no bounds checking, could crash with certain input_idsNew Features
HybridNgramHashMapping
Replaces
NgramHashMappingwith a propernn.Modulethat supports both CPU and GPU:Key changes:
register_buffer()for automatic device transfer_hash_gpu()usestorch.bitwise_xorinstead of numpyEngramConfig.gpu_thresholdCompressedTokenizer
compress_cpu(): fast numpy path with bounds checkingcompress_gpu(): lazy tensor initialization, tracks deviceBenchmark Suite
New files for validation:
benchmark.py: measures latency across configstest_correctness.py: verifies numerical equivalenceBenchmark Results
Tested on NVIDIA GPU with batch_size=[2,4,8], seq_len=[128,256,512]
Backward Compatibility
engram_demo_v1.pyunchanged