Modified frame jumping behavior. #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved frame info to left of video and filters to right of video. Moved jumptoframe to its own component.
Added margins and padding to align video frame, annotations scrub bar, and annotations bar. Reduced width of text in annotations bar.
Fixed error in JumpToFrame where previously, clicking the "Jump to Frame" button did not change the current video frame. Moved it inside video controls and made minor visual changes. Changed icon of step forward and step back button to chevrons.
Aligned FrameInfo box with left side of video. Removed JumpToFrame button and replaced with 'send' button inside the text field to save vertical space. Adjusted placeholder text so that it is centered. Implemented validation for input so that when user inputs invalid frame number, input box turns red and error tooltip appears.
Fixed a bug in the jump to frame input where a negative number was previously marked as valid. Made an update to retrieve the total frames from videoData.metadata.numFrames.
Updating to have new iCatcher release
Temporary fix to allow code to compile after merge.
Implemented visual layout for EditorBox. No functionality yet.
Adjusted the tooltip for the max int user can input for jumptoframe.
Deleting unused files. VideoHeader's contents were previously moved into FrameInfo and VideoHeader was removed from the UI.
Created css variables for component box settings - background color, padding, shadow.
Made the label selector and included selector a controlled component and set the initial value to an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When jumping through frames after filtering by specific labels, should jump to endpoints, rather than each individual frame.