feat(api/config): Add Lifecycle types into Config#121
Open
lshemesh wants to merge 1 commit intodeis:masterfrom
Open
feat(api/config): Add Lifecycle types into Config#121lshemesh wants to merge 1 commit intodeis:masterfrom
lshemesh wants to merge 1 commit intodeis:masterfrom
Conversation
Introducing lifecycle hooks into Deis workflow requires that these types be added to config. This change is required in order to make further changes to deiscli and in conjunction with deis/controller#1311
Member
|
Jenkins, test this please. |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 70.71% 68.38% -2.33%
==========================================
Files 28 28
Lines 898 1202 +304
==========================================
+ Hits 635 822 +187
- Misses 147 264 +117
Partials 116 116
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing lifecycle hooks into Deis workflow requires that these types be added to config. These changes will work along side deis/controller#1311 and further changes in deiscli.