Skip to content

switch to a simplified configuration for httpd#57

Open
PPN-SD wants to merge 1 commit intodeiv:masterfrom
PPN-SD:fix_libws44
Open

switch to a simplified configuration for httpd#57
PPN-SD wants to merge 1 commit intodeiv:masterfrom
PPN-SD:fix_libws44

Conversation

@PPN-SD
Copy link

@PPN-SD PPN-SD commented Sep 11, 2025

because params are default values

tested with libwebsockets-4.3/4.4 and driftnet-1.5.0 / 1.6.0

Closes: #55

@PPN-SD
Copy link
Author

PPN-SD commented Sep 11, 2025

Not tested with driftnet 1.6.0 because I got an 404 error whatever with libwebsockets 4.3 or 4.4.

@deiv
Copy link
Owner

deiv commented Oct 25, 2025

@PPN-SD At first sight, looks good to me. But it makes me doubt about the next points:

  • mime_types was overriden to allow to recognize webp images (and some obscure jpeg too). So, this will not break that?
  • If we are getting 404 in 1.6.0, then this change is in some way broken ?

@PPN-SD
Copy link
Author

PPN-SD commented Oct 25, 2025

@PPN-SD At first sight, looks good to me. But it makes me doubt about the next points:

  • mime_types was overriden to allow to recognize webp images (and some obscure jpeg too). So, this will not break that?

hum, let me check. webp is not in libwebsocket list indeed.

  • If we are getting 404 in 1.6.0, then this change is in some way broken ?

this is another issue. patch applied or not doesnt change anything. maybe html files needs to be installed in a specific dir ?

@deiv
Copy link
Owner

deiv commented Oct 25, 2025

@PPN-SD At first sight, looks good to me. But it makes me doubt about the next points:

  • mime_types was overriden to allow to recognize webp images (and some obscure jpeg too). So, this will not break that?

hum, let me check. webp is not in libwebsocket list indeed.

;)

  • If we are getting 404 in 1.6.0, then this change is in some way broken ?

this is another issue. patch applied or not doesnt change anything. maybe html files needs to be installed in a specific dir ?

Yep, static files, if not overriden, should live in /usr/share. For development purpouse try --enable-http-display-in-src-statics configure flag, that should do the job (src dir static files will be used instead of /usr/share ones).

@PPN-SD
Copy link
Author

PPN-SD commented Oct 25, 2025

--enable-http-display-in-src-statics

ok, it didn't work (err 404) with src-statics the last time I checked. Anyway, use files in /usr/share is fine. The question is why it doesnt work with 1.6 but does with 1.5.

@deiv
Copy link
Owner

deiv commented Oct 26, 2025

--enable-http-display-in-src-statics

ok, it didn't work (err 404) with src-statics the last time I checked. Anyway, use files in /usr/share is fine. The question is why it doesnt work with 1.6 but does with 1.5.

Then, I'm not in the mood to merge the PR, until the situation is fixed.

Probably the 404 is related to the former changes.

@PPN-SD PPN-SD marked this pull request as draft October 26, 2025 19:49
because params are default values
@PPN-SD
Copy link
Author

PPN-SD commented Oct 26, 2025

mime_types added and tested.
404 appears because the path for index.hml is wrong with 1.6.0 but not for 1.5.0, but it could be a side effect of the distribution.

@PPN-SD PPN-SD marked this pull request as ready for review October 26, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fails to build with libwebsockets 4.4.1

2 participants