Skip to content

fix: use Assert.HasCount instead of Assert.AreEqual for collection count (MSTEST0037)#6

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-count-assertion-issue
Mar 1, 2026
Merged

fix: use Assert.HasCount instead of Assert.AreEqual for collection count (MSTEST0037)#6
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-count-assertion-issue

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

Pull Request

Description

Resolves MSTEST0037 code smell in ContextTests.cs where Assert.AreEqual was used to check collection count instead of the purpose-built Assert.HasCount, which produces clearer failure messages.

  • ContextTests.cs line 216: Replace Assert.AreEqual(1, context.Packages.Count) with Assert.HasCount(1, context.Packages)
// Before
Assert.AreEqual(1, context.Packages.Count);

// After
Assert.HasCount(1, context.Packages);

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.NuGet.CacheTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Single-line change addressing the static analysis warning flagged by the external Roslyn analyzer.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…unt (MSTEST0037)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix count assertion issue in ContextTests fix: use Assert.HasCount instead of Assert.AreEqual for collection count (MSTEST0037) Mar 1, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 1, 2026 14:06
@Malcolmnixon Malcolmnixon merged commit bb85ba3 into main Mar 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants